projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d1220e4
)
rtc: max31335: Fix ignored return value in set_alarm
author
Nuno Sá
<nuno.sa@analog.com>
Fri, 28 Nov 2025 16:36:38 +0000
(16:36 +0000)
committer
Alexandre Belloni
<alexandre.belloni@bootlin.com>
Mon, 8 Dec 2025 21:55:39 +0000
(22:55 +0100)
Return the result from regmap_update_bits() instead of ignoring it
and always returning 0.
Fixes:
dedaf03b99d6
("rtc: max31335: add driver support")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Link:
https://patch.msgid.link/20251128-max31335-handler-error-v1-1-6b6f7f78dbda@analog.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-max31335.c
patch
|
blob
|
history
diff --git
a/drivers/rtc/rtc-max31335.c
b/drivers/rtc/rtc-max31335.c
index
dfb5bad
..
23b7bf1
100644
(file)
--- a/
drivers/rtc/rtc-max31335.c
+++ b/
drivers/rtc/rtc-max31335.c
@@
-391,10
+391,8
@@
static int max31335_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
if (ret)
return ret;
- ret = regmap_update_bits(max31335->regmap, max31335->chip->int_status_reg,
- MAX31335_STATUS1_A1F, 0);
-
- return 0;
+ return regmap_update_bits(max31335->regmap, max31335->chip->int_status_reg,
+ MAX31335_STATUS1_A1F, 0);
}
static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled)