drm/i915/selftests: Fix return in assert_mmap_offset()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 28 Feb 2020 14:14:13 +0000 (17:14 +0300)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 28 Feb 2020 21:13:16 +0000 (21:13 +0000)
The assert_mmap_offset() returns type bool so if we return an error
pointer that is "return true;" or success.  If we have an error, then
we should return false.

Fixes: 3d81d589d6e3 ("drm/i915: Test exhaustion of the mmap space")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200228141413.qfjf4abr323drlo4@kili.mountain
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c

index ef7c74c..43912e9 100644 (file)
@@ -570,7 +570,7 @@ static bool assert_mmap_offset(struct drm_i915_private *i915,
 
        obj = i915_gem_object_create_internal(i915, size);
        if (IS_ERR(obj))
-               return PTR_ERR(obj);
+               return false;
 
        mmo = mmap_offset_attach(obj, I915_MMAP_OFFSET_GTT, NULL);
        i915_gem_object_put(obj);