qlge: make nic_operations struct const
authorstephen hemminger <shemminger@vyatta.com>
Thu, 14 Apr 2011 05:51:52 +0000 (05:51 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Apr 2011 04:53:43 +0000 (21:53 -0700)
The struct nic_operations is just function pointers and should be
declared const for added security.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/qlge/qlge.h
drivers/net/qlge/qlge_main.c

index 4757c59..d328507 100644 (file)
@@ -2134,7 +2134,7 @@ struct ql_adapter {
        struct delayed_work mpi_idc_work;
        struct delayed_work mpi_core_to_log;
        struct completion ide_completion;
-       struct nic_operations *nic_ops;
+       const struct nic_operations *nic_ops;
        u16 device_id;
        struct timer_list timer;
        atomic_t lb_count;
index 5bb3119..f61e717 100644 (file)
@@ -4412,12 +4412,12 @@ error:
        rtnl_unlock();
 }
 
-static struct nic_operations qla8012_nic_ops = {
+static const struct nic_operations qla8012_nic_ops = {
        .get_flash              = ql_get_8012_flash_params,
        .port_initialize        = ql_8012_port_initialize,
 };
 
-static struct nic_operations qla8000_nic_ops = {
+static const struct nic_operations qla8000_nic_ops = {
        .get_flash              = ql_get_8000_flash_params,
        .port_initialize        = ql_8000_port_initialize,
 };