net: phy: dp83867: move dt parsing to probe
authorGrygorii Strashko <grygorii.strashko@ti.com>
Wed, 23 Oct 2019 14:48:46 +0000 (17:48 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 26 Oct 2019 02:24:47 +0000 (19:24 -0700)
Move DT parsing code to probe dp83867_probe() as it's one time operation.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/dp83867.c

index cf4455b..5816a06 100644 (file)
@@ -299,7 +299,7 @@ static int dp83867_probe(struct phy_device *phydev)
 
        phydev->priv = dp83867;
 
-       return 0;
+       return dp83867_of_init(phydev);
 }
 
 static int dp83867_config_init(struct phy_device *phydev)
@@ -308,10 +308,6 @@ static int dp83867_config_init(struct phy_device *phydev)
        int ret, val, bs;
        u16 delay;
 
-       ret = dp83867_of_init(phydev);
-       if (ret)
-               return ret;
-
        /* RX_DV/RX_CTRL strapped in mode 1 or mode 2 workaround */
        if (dp83867->rxctrl_strap_quirk)
                phy_clear_bits_mmd(phydev, DP83867_DEVADDR, DP83867_CFG4,