btrfs: remove SLAB_MEM_SPREAD flag use
authorChengming Zhou <zhouchengming@bytedance.com>
Sat, 24 Feb 2024 13:47:09 +0000 (13:47 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 5 Mar 2024 16:13:23 +0000 (17:13 +0100)
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
12 files changed:
fs/btrfs/backref.c
fs/btrfs/ctree.c
fs/btrfs/defrag.c
fs/btrfs/delayed-inode.c
fs/btrfs/delayed-ref.c
fs/btrfs/extent-io-tree.c
fs/btrfs/extent_io.c
fs/btrfs/extent_map.c
fs/btrfs/free-space-cache.c
fs/btrfs/inode.c
fs/btrfs/ordered-data.c
fs/btrfs/transaction.c

index 6514cb1..c1e6a5b 100644 (file)
@@ -198,10 +198,7 @@ static struct kmem_cache *btrfs_prelim_ref_cache;
 int __init btrfs_prelim_ref_init(void)
 {
        btrfs_prelim_ref_cache = kmem_cache_create("btrfs_prelim_ref",
-                                       sizeof(struct prelim_ref),
-                                       0,
-                                       SLAB_MEM_SPREAD,
-                                       NULL);
+                                       sizeof(struct prelim_ref), 0, 0, NULL);
        if (!btrfs_prelim_ref_cache)
                return -ENOMEM;
        return 0;
index bae17db..aaf53fd 100644 (file)
@@ -5086,7 +5086,7 @@ int btrfs_previous_extent_item(struct btrfs_root *root,
 
 int __init btrfs_ctree_init(void)
 {
-       btrfs_path_cachep = KMEM_CACHE(btrfs_path, SLAB_MEM_SPREAD);
+       btrfs_path_cachep = KMEM_CACHE(btrfs_path, 0);
        if (!btrfs_path_cachep)
                return -ENOMEM;
        return 0;
index f17833a..f015fa1 100644 (file)
@@ -1510,9 +1510,7 @@ void __cold btrfs_auto_defrag_exit(void)
 int __init btrfs_auto_defrag_init(void)
 {
        btrfs_inode_defrag_cachep = kmem_cache_create("btrfs_inode_defrag",
-                                       sizeof(struct inode_defrag), 0,
-                                       SLAB_MEM_SPREAD,
-                                       NULL);
+                                       sizeof(struct inode_defrag), 0, 0, NULL);
        if (!btrfs_inode_defrag_cachep)
                return -ENOMEM;
 
index 0a7a40d..dd6f566 100644 (file)
@@ -28,7 +28,7 @@ static struct kmem_cache *delayed_node_cache;
 
 int __init btrfs_delayed_inode_init(void)
 {
-       delayed_node_cache = KMEM_CACHE(btrfs_delayed_node, SLAB_MEM_SPREAD);
+       delayed_node_cache = KMEM_CACHE(btrfs_delayed_node, 0);
        if (!delayed_node_cache)
                return -ENOMEM;
        return 0;
index c90efc2..e44e62c 100644 (file)
@@ -1307,23 +1307,19 @@ void __cold btrfs_delayed_ref_exit(void)
 
 int __init btrfs_delayed_ref_init(void)
 {
-       btrfs_delayed_ref_head_cachep = KMEM_CACHE(btrfs_delayed_ref_head,
-                                                  SLAB_MEM_SPREAD);
+       btrfs_delayed_ref_head_cachep = KMEM_CACHE(btrfs_delayed_ref_head, 0);
        if (!btrfs_delayed_ref_head_cachep)
                goto fail;
 
-       btrfs_delayed_tree_ref_cachep = KMEM_CACHE(btrfs_delayed_tree_ref,
-                                                  SLAB_MEM_SPREAD);
+       btrfs_delayed_tree_ref_cachep = KMEM_CACHE(btrfs_delayed_tree_ref, 0);
        if (!btrfs_delayed_tree_ref_cachep)
                goto fail;
 
-       btrfs_delayed_data_ref_cachep = KMEM_CACHE(btrfs_delayed_data_ref,
-                                                  SLAB_MEM_SPREAD);
+       btrfs_delayed_data_ref_cachep = KMEM_CACHE(btrfs_delayed_data_ref, 0);
        if (!btrfs_delayed_data_ref_cachep)
                goto fail;
 
-       btrfs_delayed_extent_op_cachep = KMEM_CACHE(btrfs_delayed_extent_op,
-                                                   SLAB_MEM_SPREAD);
+       btrfs_delayed_extent_op_cachep = KMEM_CACHE(btrfs_delayed_extent_op, 0);
        if (!btrfs_delayed_extent_op_cachep)
                goto fail;
 
index 6b923c0..c09b428 100644 (file)
@@ -1883,8 +1883,8 @@ void __cold extent_state_free_cachep(void)
 int __init extent_state_init_cachep(void)
 {
        extent_state_cache = kmem_cache_create("btrfs_extent_state",
-                       sizeof(struct extent_state), 0,
-                       SLAB_MEM_SPREAD, NULL);
+                                              sizeof(struct extent_state), 0, 0,
+                                              NULL);
        if (!extent_state_cache)
                return -ENOMEM;
 
index e73bffc..e6a2b6e 100644 (file)
@@ -146,8 +146,8 @@ static void submit_write_bio(struct btrfs_bio_ctrl *bio_ctrl, int ret)
 int __init extent_buffer_init_cachep(void)
 {
        extent_buffer_cache = kmem_cache_create("btrfs_extent_buffer",
-                       sizeof(struct extent_buffer), 0,
-                       SLAB_MEM_SPREAD, NULL);
+                                               sizeof(struct extent_buffer), 0, 0,
+                                               NULL);
        if (!extent_buffer_cache)
                return -ENOMEM;
 
index ea08601..347ca13 100644 (file)
@@ -15,8 +15,7 @@ static struct kmem_cache *extent_map_cache;
 int __init extent_map_init(void)
 {
        extent_map_cache = kmem_cache_create("btrfs_extent_map",
-                       sizeof(struct extent_map), 0,
-                       SLAB_MEM_SPREAD, NULL);
+                                            sizeof(struct extent_map), 0, 0, NULL);
        if (!extent_map_cache)
                return -ENOMEM;
        return 0;
index d984912..c8a05d5 100644 (file)
@@ -4154,13 +4154,13 @@ out:
 
 int __init btrfs_free_space_init(void)
 {
-       btrfs_free_space_cachep = KMEM_CACHE(btrfs_free_space, SLAB_MEM_SPREAD);
+       btrfs_free_space_cachep = KMEM_CACHE(btrfs_free_space, 0);
        if (!btrfs_free_space_cachep)
                return -ENOMEM;
 
        btrfs_free_space_bitmap_cachep = kmem_cache_create("btrfs_free_space_bitmap",
                                                        PAGE_SIZE, PAGE_SIZE,
-                                                       SLAB_MEM_SPREAD, NULL);
+                                                       0, NULL);
        if (!btrfs_free_space_bitmap_cachep) {
                kmem_cache_destroy(btrfs_free_space_cachep);
                return -ENOMEM;
index 904fff3..3770153 100644 (file)
@@ -8730,7 +8730,7 @@ int __init btrfs_init_cachep(void)
 {
        btrfs_inode_cachep = kmem_cache_create("btrfs_inode",
                        sizeof(struct btrfs_inode), 0,
-                       SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT,
+                       SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
                        init_once);
        if (!btrfs_inode_cachep)
                goto fail;
index 1ee2fb8..b749ba4 100644 (file)
@@ -1235,7 +1235,7 @@ struct btrfs_ordered_extent *btrfs_split_ordered_extent(
 
 int __init ordered_data_init(void)
 {
-       btrfs_ordered_extent_cache = KMEM_CACHE(btrfs_ordered_extent, SLAB_MEM_SPREAD);
+       btrfs_ordered_extent_cache = KMEM_CACHE(btrfs_ordered_extent, 0);
        if (!btrfs_ordered_extent_cache)
                return -ENOMEM;
 
index 31ac5a0..46e8426 100644 (file)
@@ -2671,8 +2671,7 @@ void __cold __btrfs_abort_transaction(struct btrfs_trans_handle *trans,
 
 int __init btrfs_transaction_init(void)
 {
-       btrfs_trans_handle_cachep = KMEM_CACHE(btrfs_trans_handle,
-                                              SLAB_TEMPORARY | SLAB_MEM_SPREAD);
+       btrfs_trans_handle_cachep = KMEM_CACHE(btrfs_trans_handle, SLAB_TEMPORARY);
        if (!btrfs_trans_handle_cachep)
                return -ENOMEM;
        return 0;