drm/ttm: fix uncached page deallocation to properly fill page pool v3.
authorJérôme Glisse <jglisse@redhat.com>
Thu, 9 Jul 2015 18:19:29 +0000 (14:19 -0400)
committerDave Airlie <airlied@redhat.com>
Fri, 17 Jul 2015 08:17:33 +0000 (18:17 +1000)
Current code never allowed the page pool to actualy fill in anyway.
This fix it, so that we only start freeing page from the pool when
we go over the pool size.

Changed since v1:
  - Move the page batching optimization to its separate patch.

Changed since v2:
  - Do not remove code part of the batching optimization with
    this patch.
  - Better commit message.

Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Reviewed-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-and-Tested-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c

index 3077f15..af23080 100644 (file)
@@ -963,7 +963,6 @@ void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct device *dev)
        } else {
                pool->npages_free += count;
                list_splice(&ttm_dma->pages_list, &pool->free_list);
-               npages = count;
                if (pool->npages_free > _manager->options.max_size) {
                        npages = pool->npages_free - _manager->options.max_size;
                        /* free at least NUM_PAGES_TO_ALLOC number of pages