mtd: spinand: winbond: Configure the IO mode after the dummy cycles

When we will change the bus interface, the action that actually performs
the transition is the IO mode register write. This means after the IO
mode register write, we should use the new bus interface. But the
->configure_chip() hook itself is not responsible of making this change
official, it is the caller that must act according to the return value.

Reorganize this helper to first configure the dummy cycles before
possibly switching to another bus interface.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c
index b169636..1d79a8a 100644 (file)
--- a/drivers/mtd/nand/spi/winbond.c
+++ b/drivers/mtd/nand/spi/winbond.c
@@ -381,21 +381,6 @@ static int w35n0xjw_vcr_cfg(struct spinand_device *spinand)
 
        op = spinand->op_templates->read_cache;
 
-       single = (op->cmd.buswidth == 1 && op->addr.buswidth == 1 && op->data.buswidth == 1);
-       dtr = (op->cmd.dtr || op->addr.dtr || op->data.dtr);
-       if (single && !dtr)
-               io_mode = W35N01JW_VCR_IO_MODE_SINGLE_SDR;
-       else if (!single && !dtr)
-               io_mode = W35N01JW_VCR_IO_MODE_OCTAL_SDR;
-       else if (!single && dtr)
-               io_mode = W35N01JW_VCR_IO_MODE_OCTAL_DDR;
-       else
-               return -EINVAL;
-
-       ret = w35n0xjw_write_vcr(spinand, W35N01JW_VCR_IO_MODE_REG, io_mode);
-       if (ret)
-               return ret;
-
        dummy_cycles = ((op->dummy.nbytes * 8) / op->dummy.buswidth) / (op->dummy.dtr ? 2 : 1);
        switch (dummy_cycles) {
        case 8:
@@ -413,6 +398,21 @@ static int w35n0xjw_vcr_cfg(struct spinand_device *spinand)
        if (ret)
                return ret;
 
+       single = (op->cmd.buswidth == 1 && op->addr.buswidth == 1 && op->data.buswidth == 1);
+       dtr = (op->cmd.dtr && op->addr.dtr && op->data.dtr);
+       if (single && !dtr)
+               io_mode = W35N01JW_VCR_IO_MODE_SINGLE_SDR;
+       else if (!single && !dtr)
+               io_mode = W35N01JW_VCR_IO_MODE_OCTAL_SDR;
+       else if (!single && dtr)
+               io_mode = W35N01JW_VCR_IO_MODE_OCTAL_DDR;
+       else
+               return -EINVAL;
+
+       ret = w35n0xjw_write_vcr(spinand, W35N01JW_VCR_IO_MODE_REG, io_mode);
+       if (ret)
+               return ret;
+
        return 0;
 }