wifi: mt76: mt7996: drop always true condition of __mt7996_reg_addr()
authorRyder Lee <ryder.lee@mediatek.com>
Sun, 4 Dec 2022 07:18:15 +0000 (15:18 +0800)
committerFelix Fietkau <nbd@nbd.name>
Fri, 9 Dec 2022 15:45:39 +0000 (16:45 +0100)
addr <= MT_CBTOP2_PHY_END(0xffffffff) is always true (<= u32max),
so drop it.

Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices")
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/mmio.c
drivers/net/wireless/mediatek/mt76/mt7996/regs.h

index 521769e..60781d0 100644 (file)
@@ -149,7 +149,7 @@ static u32 __mt7996_reg_addr(struct mt7996_dev *dev, u32 addr)
 
        if (dev_is_pci(dev->mt76.dev) &&
            ((addr >= MT_CBTOP1_PHY_START && addr <= MT_CBTOP1_PHY_END) ||
-            (addr >= MT_CBTOP2_PHY_START && addr <= MT_CBTOP2_PHY_END)))
+           addr >= MT_CBTOP2_PHY_START))
                return mt7996_reg_map_l1(dev, addr);
 
        /* CONN_INFRA: covert to phyiscal addr and use layer 1 remap */
index 794f61b..42980b9 100644 (file)
@@ -463,7 +463,6 @@ enum base_rev {
 #define MT_CBTOP1_PHY_START                    0x70000000
 #define MT_CBTOP1_PHY_END                      0x77ffffff
 #define MT_CBTOP2_PHY_START                    0xf0000000
-#define MT_CBTOP2_PHY_END                      0xffffffff
 #define MT_INFRA_MCU_START                     0x7c000000
 #define MT_INFRA_MCU_END                       0x7c3fffff