kasan: print workqueue stack
authorWalter Wu <walter-zh.wu@mediatek.com>
Tue, 15 Dec 2020 03:09:13 +0000 (19:09 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 15 Dec 2020 20:13:42 +0000 (12:13 -0800)
The aux_stack[2] is reused to record the call_rcu() call stack and
enqueuing work call stacks.  So that we need to change the auxiliary stack
title for common title, print them in KASAN report.

Link: https://lkml.kernel.org/r/20201203022715.30635-1-walter-zh.wu@mediatek.com
Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
Suggested-by: Marco Elver <elver@google.com>
Acked-by: Marco Elver <elver@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Andrey Konovalov <andreyknvl@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/kasan/generic.c
mm/kasan/report.c

index 248264b..30c0a50 100644 (file)
@@ -339,9 +339,6 @@ void kasan_record_aux_stack(void *addr)
        object = nearest_obj(cache, page, addr);
        alloc_info = get_alloc_info(cache, object);
 
-       /*
-        * record the last two call_rcu() call stacks.
-        */
        alloc_info->aux_stack[1] = alloc_info->aux_stack[0];
        alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT);
 }
index 00a53f1..5a0102f 100644 (file)
@@ -185,12 +185,12 @@ static void describe_object(struct kmem_cache *cache, void *object,
 
 #ifdef CONFIG_KASAN_GENERIC
                if (alloc_info->aux_stack[0]) {
-                       pr_err("Last call_rcu():\n");
+                       pr_err("Last potentially related work creation:\n");
                        print_stack(alloc_info->aux_stack[0]);
                        pr_err("\n");
                }
                if (alloc_info->aux_stack[1]) {
-                       pr_err("Second to last call_rcu():\n");
+                       pr_err("Second to last potentially related work creation:\n");
                        print_stack(alloc_info->aux_stack[1]);
                        pr_err("\n");
                }