wifi: rtlwifi: remove always-true condition pointed out by GCC 12
authorJakub Kicinski <kuba@kernel.org>
Fri, 20 May 2022 19:43:15 +0000 (12:43 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 May 2022 00:23:05 +0000 (17:23 -0700)
The .value is a two-dim array, not a pointer.

struct iqk_matrix_regs {
bool iqk_done;
        long value[1][IQK_MATRIX_REG_NUM];
};

Acked-by: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c

index 51fe51b..15e6a6a 100644 (file)
@@ -2386,10 +2386,7 @@ void rtl92d_phy_reload_iqk_setting(struct ieee80211_hw *hw, u8 channel)
                        rtl_dbg(rtlpriv, COMP_SCAN, DBG_LOUD,
                                "Just Read IQK Matrix reg for channel:%d....\n",
                                channel);
-                       if ((rtlphy->iqk_matrix[indexforchannel].
-                            value[0] != NULL)
-                               /*&&(regea4 != 0) */)
-                               _rtl92d_phy_patha_fill_iqk_matrix(hw, true,
+                       _rtl92d_phy_patha_fill_iqk_matrix(hw, true,
                                        rtlphy->iqk_matrix[
                                        indexforchannel].value, 0,
                                        (rtlphy->iqk_matrix[