platform/surface: surface3_power: Use i2c_acpi_get_i2c_resource() helper
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 3 Aug 2021 16:32:52 +0000 (19:32 +0300)
committerHans de Goede <hdegoede@redhat.com>
Thu, 12 Aug 2021 07:26:28 +0000 (09:26 +0200)
ACPI provides a generic helper to get I²C Serial Bus resources.
Use it instead of open coded variant.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210803163252.60141-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/surface/surface3_power.c

index dea82aa..90c1568 100644 (file)
@@ -384,13 +384,7 @@ mshw0011_space_handler(u32 function, acpi_physical_address command,
        if (ACPI_FAILURE(ret))
                return ret;
 
-       if (!value64 || ares->type != ACPI_RESOURCE_TYPE_SERIAL_BUS) {
-               ret = AE_BAD_PARAMETER;
-               goto err;
-       }
-
-       sb = &ares->data.i2c_serial_bus;
-       if (sb->type != ACPI_RESOURCE_SERIAL_TYPE_I2C) {
+       if (!value64 || !i2c_acpi_get_i2c_resource(ares, &sb)) {
                ret = AE_BAD_PARAMETER;
                goto err;
        }