of: property: Fix create device links for all child-supplier dependencies
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Mon, 20 Apr 2020 12:01:01 +0000 (14:01 +0200)
committerRob Herring <robh@kernel.org>
Tue, 28 Apr 2020 17:47:47 +0000 (12:47 -0500)
Upon adding a new device from a DT node, we scan its properties and its
children's properties in order to create a consumer/supplier
relationship between the device and the property provider.

That said, it's possible for some of the node's children to be disabled,
which will create links that'll never be fulfilled.

To get around this, use the for_each_available_child_of_node() function
instead of for_each_available_node() when iterating over the node's
children.

Fixes: d4387cd11741 ("of: property: Create device links for all child-supplier depencencies")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Saravana Kannan <saravanak@google.com>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/property.c

index ee1bc26..9674b3c 100644 (file)
@@ -1298,7 +1298,7 @@ static int of_link_to_suppliers(struct device *dev,
                if (of_link_property(dev, con_np, p->name))
                        ret = -ENODEV;
 
-       for_each_child_of_node(con_np, child)
+       for_each_available_child_of_node(con_np, child)
                if (of_link_to_suppliers(dev, child) && !ret)
                        ret = -EAGAIN;