mmc: mtk-sd: fix devm_clk_get_optional usage
authorRosen Penev <rosenp@gmail.com>
Mon, 30 Sep 2024 22:49:19 +0000 (15:49 -0700)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 14 Oct 2024 10:40:10 +0000 (12:40 +0200)
This already returns NULL when not found. However, it can return
EPROBE_DEFER and should thus return here.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://lore.kernel.org/r/20240930224919.355359-4-rosenp@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mtk-sd.c

index 41ad650..1efe434 100644 (file)
@@ -2794,9 +2794,8 @@ static int msdc_drv_probe(struct platform_device *pdev)
        if (!(mmc->caps2 & MMC_CAP2_NO_MMC)) {
                host->crypto_clk = devm_clk_get_optional(&pdev->dev, "crypto");
                if (IS_ERR(host->crypto_clk))
-                       host->crypto_clk = NULL;
-               else
-                       mmc->caps2 |= MMC_CAP2_CRYPTO;
+                       return PTR_ERR(host->crypto_clk);
+               mmc->caps2 |= MMC_CAP2_CRYPTO;
        }
 
        host->irq = platform_get_irq(pdev, 0);