media: lmedm04: remove redundant assignment to variable gate
authorColin Ian King <colin.king@canonical.com>
Mon, 10 Feb 2020 14:58:44 +0000 (15:58 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 12 Mar 2020 08:47:33 +0000 (09:47 +0100)
The variable gate is being initialized and also checked and re-assigned
with values that are never read as it is being re-assigned later in a
for-loop with a new value.  The assignments are redundant and can be
removed.

Addresses Coverity ("Unused value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/dvb-usb-v2/lmedm04.c

index 62d3566..fd8b42b 100644 (file)
@@ -486,13 +486,10 @@ static int lme2510_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msg[],
        static u8 obuf[64], ibuf[64];
        int i, read, read_o;
        u16 len;
-       u8 gate = st->i2c_gate;
+       u8 gate;
 
        mutex_lock(&d->i2c_mutex);
 
-       if (gate == 0)
-               gate = 5;
-
        for (i = 0; i < num; i++) {
                read_o = msg[i].flags & I2C_M_RD;
                read = i + 1 < num && msg[i + 1].flags & I2C_M_RD;