radeon: insert 10ms sleep in dce5_crtc_load_lut
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 28 Jan 2020 16:09:52 +0000 (17:09 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 30 Jan 2020 22:15:42 +0000 (17:15 -0500)
Per at least one tester this is enough magic to recover the regression
introduced for some people (but not all) in

commit b8e2b0199cc377617dc238f5106352c06dcd3fa2
Author: Peter Rosin <peda@axentia.se>
Date:   Tue Jul 4 12:36:57 2017 +0200

    drm/fb-helper: factor out pseudo-palette

which for radeon had the side-effect of refactoring out a seemingly
redudant writing of the color palette.

10ms in a fairly slow modeset path feels like an acceptable form of
duct-tape, so maybe worth a shot and see what sticks.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Michel Dänzer <michel.daenzer@amd.com>
References: https://bugzilla.kernel.org/show_bug.cgi?id=198123
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_display.c

index 856526c..82fa7ab 100644 (file)
@@ -127,6 +127,8 @@ static void dce5_crtc_load_lut(struct drm_crtc *crtc)
 
        DRM_DEBUG_KMS("%d\n", radeon_crtc->crtc_id);
 
+       msleep(10);
+
        WREG32(NI_INPUT_CSC_CONTROL + radeon_crtc->crtc_offset,
               (NI_INPUT_CSC_GRPH_MODE(NI_INPUT_CSC_BYPASS) |
                NI_INPUT_CSC_OVL_MODE(NI_INPUT_CSC_BYPASS)));