smack: Remove redundant assignments
authorMichal Orzel <michalorzel.eng@gmail.com>
Thu, 31 Mar 2022 17:33:58 +0000 (19:33 +0200)
committerCasey Schaufler <casey@schaufler-ca.com>
Mon, 23 May 2022 18:12:08 +0000 (11:12 -0700)
Get rid of redundant assignments which end up in values not being
read either because they are overwritten or the function ends.

Reported by clang-tidy [deadcode.DeadStores]

Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
security/smack/smackfs.c

index 658eab0..9e61014 100644 (file)
@@ -1192,7 +1192,6 @@ static ssize_t smk_write_net4addr(struct file *file, const char __user *buf,
                        rc = -EINVAL;
                        goto free_out;
                }
-               m = BEBITS;
                masks = 32;
        }
        if (masks > BEBITS) {