exfat: remove useless check in exfat_move_file()
authorTetsuhiro Kohada <kohada.t2@gmail.com>
Fri, 11 Sep 2020 04:45:06 +0000 (13:45 +0900)
committerNamjae Jeon <namjae.jeon@samsung.com>
Wed, 21 Oct 2020 23:29:12 +0000 (08:29 +0900)
In exfat_move_file(), the identity of source and target directory has been
checked by the caller.
Also, it gets stream.start_clu from file dir-entry, which is an invalid
determination.

Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com>
Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
fs/exfat/namei.c

index 676094f..2932b23 100644 (file)
@@ -1094,11 +1094,6 @@ static int exfat_move_file(struct inode *inode, struct exfat_chain *p_olddir,
        if (!epmov)
                return -EIO;
 
-       /* check if the source and target directory is the same */
-       if (exfat_get_entry_type(epmov) == TYPE_DIR &&
-           le32_to_cpu(epmov->dentry.stream.start_clu) == p_newdir->dir)
-               return -EINVAL;
-
        num_old_entries = exfat_count_ext_entries(sb, p_olddir, oldentry,
                epmov);
        if (num_old_entries < 0)