net: use dev_addr_set()

Use dev_addr_set() instead of writing directly to netdev->dev_addr
in various misc and old drivers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 77dc79a..0c52612 100644 (file)
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4414,7 +4414,7 @@ static int bond_set_mac_address(struct net_device *bond_dev, void *addr)
        }
 
        /* success */
-       memcpy(bond_dev->dev_addr, ss->__data, bond_dev->addr_len);
+       dev_addr_set(bond_dev, ss->__data);
        return 0;
 
 unwind:

diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
index 775dcf4..f6428ff 100644 (file)
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -791,7 +791,7 @@ static int baycom_set_mac_address(struct net_device *dev, void *addr)
        struct sockaddr *sa = (struct sockaddr *)addr;
 
        /* addr is an AX.25 shifted ASCII mac address */
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len); 
+       dev_addr_set(dev, sa->sa_data);
        return 0;                                         
 }
 

diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index d967b07..1ac8161 100644 (file)
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -302,7 +302,7 @@ static int bpq_set_mac_address(struct net_device *dev, void *addr)
 {
     struct sockaddr *sa = (struct sockaddr *)addr;
 
-    memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+    dev_addr_set(dev, sa->sa_data);
 
     return 0;
 }

diff --git a/drivers/net/hamradio/dmascc.c b/drivers/net/hamradio/dmascc.c
index f4c3efc..a4ba1b7 100644 (file)
--- a/drivers/net/hamradio/dmascc.c
+++ b/drivers/net/hamradio/dmascc.c
@@ -956,8 +956,7 @@ static int scc_send_packet(struct sk_buff *skb, struct net_device *dev)
 
 static int scc_set_mac_address(struct net_device *dev, void *sa)
 {
-       memcpy(dev->dev_addr, ((struct sockaddr *) sa)->sa_data,
-              dev->addr_len);
+       dev_addr_set(dev, ((struct sockaddr *)sa)->sa_data);
        return 0;
 }
 

diff --git a/drivers/net/hamradio/hdlcdrv.c b/drivers/net/hamradio/hdlcdrv.c
index 5805cfc..ab5327a 100644 (file)
--- a/drivers/net/hamradio/hdlcdrv.c
+++ b/drivers/net/hamradio/hdlcdrv.c
@@ -415,7 +415,7 @@ static int hdlcdrv_set_mac_address(struct net_device *dev, void *addr)
        struct sockaddr *sa = (struct sockaddr *)addr;
 
        /* addr is an AX.25 shifted ASCII mac address */
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len); 
+       dev_addr_set(dev, sa->sa_data);
        return 0;                                         
 }
 

diff --git a/drivers/net/hamradio/scc.c b/drivers/net/hamradio/scc.c
index e0bb131..9b745d0 100644 (file)
--- a/drivers/net/hamradio/scc.c
+++ b/drivers/net/hamradio/scc.c
@@ -1951,7 +1951,7 @@ static int scc_net_siocdevprivate(struct net_device *dev,
 static int scc_net_set_mac_address(struct net_device *dev, void *addr)
 {
        struct sockaddr *sa = (struct sockaddr *) addr;
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
        return 0;
 }
 

diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 6ddacbd..e557ccf 100644 (file)
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -1063,7 +1063,7 @@ static int yam_set_mac_address(struct net_device *dev, void *addr)
        struct sockaddr *sa = (struct sockaddr *) addr;
 
        /* addr is an AX.25 shifted ASCII mac address */
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
        return 0;
 }
 

diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
index 2a48924..86ec5aa 100644 (file)
--- a/drivers/net/net_failover.c
+++ b/drivers/net/net_failover.c
@@ -748,8 +748,7 @@ struct failover *net_failover_create(struct net_device *standby_dev)
        failover_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL;
        failover_dev->features |= failover_dev->hw_features;
 
-       memcpy(failover_dev->dev_addr, standby_dev->dev_addr,
-              failover_dev->addr_len);
+       dev_addr_set(failover_dev, standby_dev->dev_addr);
 
        failover_dev->min_mtu = standby_dev->min_mtu;
        failover_dev->max_mtu = standby_dev->max_mtu;

diff --git a/drivers/net/ntb_netdev.c b/drivers/net/ntb_netdev.c
index a5bab61..98ca6b1 100644 (file)
--- a/drivers/net/ntb_netdev.c
+++ b/drivers/net/ntb_netdev.c
@@ -428,7 +428,7 @@ static int ntb_netdev_probe(struct device *client_dev)
        ndev->watchdog_timeo = msecs_to_jiffies(NTB_TX_TIMEOUT_MS);
 
        eth_random_addr(ndev->perm_addr);
-       memcpy(ndev->dev_addr, ndev->perm_addr, ndev->addr_len);
+       dev_addr_set(ndev, ndev->perm_addr);
 
        ndev->netdev_ops = &ntb_netdev_ops;
        ndev->ethtool_ops = &ntb_ethtool_ops;

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index dd7917c..8b2adc5 100644 (file)
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1790,7 +1790,7 @@ static int team_set_mac_address(struct net_device *dev, void *p)
 
        if (dev->type == ARPHRD_ETHER && !is_valid_ether_addr(addr->sa_data))
                return -EADDRNOTAVAIL;
-       memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
+       dev_addr_set(dev, addr->sa_data);
        mutex_lock(&team->lock);
        list_for_each_entry(port, &team->port_list, list)
                if (team->ops.port_change_dev_addr)

diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 142f706..7a205dd 100644 (file)
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -2824,7 +2824,7 @@ vmxnet3_set_mac_addr(struct net_device *netdev, void *p)
        struct sockaddr *addr = p;
        struct vmxnet3_adapter *adapter = netdev_priv(netdev);
 
-       memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
+       dev_addr_set(netdev, addr->sa_data);
        vmxnet3_write_mac_addr(adapter, addr->sa_data);
 
        return 0;
@@ -3638,7 +3638,7 @@ vmxnet3_probe_device(struct pci_dev *pdev,
 #endif
 
        vmxnet3_read_mac_addr(adapter, mac);
-       memcpy(netdev->dev_addr,  mac, netdev->addr_len);
+       dev_addr_set(netdev, mac);
 
        netdev->netdev_ops = &vmxnet3_netdev_ops;
        vmxnet3_set_ethtool_ops(netdev);

diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 89d31ad..282192b 100644 (file)
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -301,7 +301,7 @@ static int lapbeth_set_mac_address(struct net_device *dev, void *addr)
 {
        struct sockaddr *sa = addr;
 
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
        return 0;
 }
 

diff --git a/net/802/hippi.c b/net/802/hippi.c
index f80b33a..887e73d 100644 (file)
--- a/net/802/hippi.c
+++ b/net/802/hippi.c
@@ -121,7 +121,7 @@ int hippi_mac_addr(struct net_device *dev, void *p)
        struct sockaddr *addr = p;
        if (netif_running(dev))
                return -EBUSY;
-       memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
+       dev_addr_set(dev, addr->sa_data);
        return 0;
 }
 EXPORT_SYMBOL(hippi_mac_addr);

diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index dd2a8da..11854fd 100644 (file)
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -578,7 +578,7 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
        if (list_empty(&brdev->brvccs) && !brdev->mac_was_set) {
                unsigned char *esi = atmvcc->dev->esi;
                if (esi[0] | esi[1] | esi[2] | esi[3] | esi[4] | esi[5])
-                       memcpy(net_dev->dev_addr, esi, net_dev->addr_len);
+                       dev_addr_set(net_dev, esi);
                else
                        net_dev->dev_addr[2] = 1;
        }

diff --git a/net/netrom/nr_dev.c b/net/netrom/nr_dev.c
index 29e418c..d1ca413 100644 (file)
--- a/net/netrom/nr_dev.c
+++ b/net/netrom/nr_dev.c
@@ -111,7 +111,7 @@ static int __must_check nr_set_mac_address(struct net_device *dev, void *addr)
                ax25_listen_release((ax25_address *)dev->dev_addr, NULL);
        }
 
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
 
        return 0;
 }

diff --git a/net/rose/rose_dev.c b/net/rose/rose_dev.c
index 051804f..2a35e18 100644 (file)
--- a/net/rose/rose_dev.c
+++ b/net/rose/rose_dev.c
@@ -69,7 +69,7 @@ static int rose_set_mac_address(struct net_device *dev, void *addr)
                rose_del_loopback_node((rose_address *)dev->dev_addr);
        }
 
-       memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);
+       dev_addr_set(dev, sa->sa_data);
 
        return 0;
 }