sched/core: Update stale comment in try_to_wake_up()
authorIngo Molnar <mingo@kernel.org>
Wed, 4 Oct 2023 09:33:36 +0000 (11:33 +0200)
committerIngo Molnar <mingo@kernel.org>
Sat, 7 Oct 2023 09:33:28 +0000 (11:33 +0200)
The following commit:

  9b3c4ab3045e ("sched,rcu: Rework try_invoke_on_locked_down_task()")

... renamed try_invoke_on_locked_down_task() to task_call_func(),
but forgot to update the comment in try_to_wake_up().

But it turns out that the smp_rmb() doesn't live in task_call_func()
either, it was moved to __task_needs_rq_lock() in:

  91dabf33ae5d ("sched: Fix race in task_call_func()")

Fix that now.

Also fix the s/smb/smp typo while at it.

Reported-by: Zhang Qiao <zhangqiao22@huawei.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230731085759.11443-1-zhangqiao22@huawei.com
kernel/sched/core.c

index 65e10ac..f5783cb 100644 (file)
@@ -4237,7 +4237,7 @@ int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
                 * Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in
                 * __schedule().  See the comment for smp_mb__after_spinlock().
                 *
-                * A similar smb_rmb() lives in try_invoke_on_locked_down_task().
+                * A similar smp_rmb() lives in __task_needs_rq_lock().
                 */
                smp_rmb();
                if (READ_ONCE(p->on_rq) && ttwu_runnable(p, wake_flags))