netkit: Remove explicit active/peer ptr initialization
authorNikolay Aleksandrov <razor@blackwall.org>
Thu, 26 Oct 2023 09:41:05 +0000 (12:41 +0300)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 26 Oct 2023 13:58:39 +0000 (15:58 +0200)
Remove the explicit NULLing of active/peer pointers and rely on the
implicit one done at net device allocation.

Suggested-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20231026094106.1505892-2-razor@blackwall.org
drivers/net/netkit.c

index 7e484f9..5a0f86f 100644 (file)
@@ -371,8 +371,6 @@ static int netkit_new_link(struct net *src_net, struct net_device *dev,
        nk->policy = default_peer;
        nk->mode = mode;
        bpf_mprog_bundle_init(&nk->bundle);
-       RCU_INIT_POINTER(nk->active, NULL);
-       RCU_INIT_POINTER(nk->peer, NULL);
 
        err = register_netdevice(peer);
        put_net(net);
@@ -398,8 +396,6 @@ static int netkit_new_link(struct net *src_net, struct net_device *dev,
        nk->policy = default_prim;
        nk->mode = mode;
        bpf_mprog_bundle_init(&nk->bundle);
-       RCU_INIT_POINTER(nk->active, NULL);
-       RCU_INIT_POINTER(nk->peer, NULL);
 
        err = register_netdevice(dev);
        if (err < 0)