net: hns3: make array spec_opcode static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Fri, 6 Sep 2019 11:28:04 +0000 (12:28 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Sep 2019 16:03:05 +0000 (18:03 +0200)
Don't populate the array spec_opcode on the stack but instead make it
static const. Makes the object code smaller by 48 bytes.

Before:
   text    data     bss     dec     hex filename
   6914    1040     128    8082    1f92 hns3/hns3vf/hclgevf_cmd.o

After:
   text    data     bss     dec     hex filename
   6866    1040     128    8034    1f62 hns3/hns3vf/hclgevf_cmd.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c

index 4c2c945..d5d1cc5 100644 (file)
@@ -74,7 +74,7 @@ static bool hclgevf_cmd_csq_done(struct hclgevf_hw *hw)
 
 static bool hclgevf_is_special_opcode(u16 opcode)
 {
-       u16 spec_opcode[] = {0x30, 0x31, 0x32};
+       static const u16 spec_opcode[] = {0x30, 0x31, 0x32};
        int i;
 
        for (i = 0; i < ARRAY_SIZE(spec_opcode); i++) {