rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock
authorGuobin Huang <huangguobin4@huawei.com>
Tue, 6 Apr 2021 12:16:46 +0000 (20:16 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 17 Apr 2021 17:34:12 +0000 (20:34 +0300)
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1617711406-49649-1-git-send-email-huangguobin4@huawei.com
drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c

index 1dbdddc..a74724c 100644 (file)
@@ -372,18 +372,14 @@ static struct pci_driver rtl92de_driver = {
 
 /* add global spin lock to solve the problem that
  * Dul mac register operation on the same time */
-spinlock_t globalmutex_power;
-spinlock_t globalmutex_for_fwdownload;
-spinlock_t globalmutex_for_power_and_efuse;
+DEFINE_SPINLOCK(globalmutex_power);
+DEFINE_SPINLOCK(globalmutex_for_fwdownload);
+DEFINE_SPINLOCK(globalmutex_for_power_and_efuse);
 
 static int __init rtl92de_module_init(void)
 {
        int ret = 0;
 
-       spin_lock_init(&globalmutex_power);
-       spin_lock_init(&globalmutex_for_fwdownload);
-       spin_lock_init(&globalmutex_for_power_and_efuse);
-
        ret = pci_register_driver(&rtl92de_driver);
        if (ret)
                WARN_ONCE(true, "rtl8192de: No device found\n");