iio: magnetometer: ak8974: make use of regmap_set_bits()
authorTrevor Gamblin <tgamblin@baylibre.com>
Mon, 17 Jun 2024 13:50:13 +0000 (09:50 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 25 Jun 2024 20:04:47 +0000 (21:04 +0100)
Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-33-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/magnetometer/ak8974.c

index d802034..961b1e0 100644 (file)
@@ -327,10 +327,7 @@ static int ak8974_trigmeas(struct ak8974 *ak8974)
        }
 
        /* Force a measurement */
-       return regmap_update_bits(ak8974->map,
-                                 AK8974_CTRL3,
-                                 AK8974_CTRL3_FORCE,
-                                 AK8974_CTRL3_FORCE);
+       return regmap_set_bits(ak8974->map, AK8974_CTRL3, AK8974_CTRL3_FORCE);
 }
 
 static int ak8974_await_drdy(struct ak8974 *ak8974)
@@ -438,10 +435,7 @@ static int ak8974_selftest(struct ak8974 *ak8974)
        }
 
        /* Trigger self-test */
-       ret = regmap_update_bits(ak8974->map,
-                       AK8974_CTRL3,
-                       AK8974_CTRL3_SELFTEST,
-                       AK8974_CTRL3_SELFTEST);
+       ret = regmap_set_bits(ak8974->map, AK8974_CTRL3, AK8974_CTRL3_SELFTEST);
        if (ret) {
                dev_err(dev, "could not write CTRL3\n");
                return ret;