scsi: fcoe: remove redundant call to skb_transport_header
authorColin Ian King <colin.king@canonical.com>
Thu, 15 Aug 2019 09:14:54 +0000 (10:14 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 29 Aug 2019 21:44:25 +0000 (17:44 -0400)
Pointer fh is being assigned a return value from the call to
skb_transport_header however this value is never read and fh is being
re-assigned immediately afterwards with a new value.  Since there are
side-effects from calling skb_transport_header the call is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fcoe/fcoe.c

index 00dd47b..8e217ab 100644 (file)
@@ -1618,7 +1618,6 @@ static inline int fcoe_filter_frames(struct fc_lport *lport,
        else
                fr_flags(fp) |= FCPHF_CRC_UNCHECKED;
 
-       fh = (struct fc_frame_header *) skb_transport_header(skb);
        fh = fc_frame_header_get(fp);
        if (fh->fh_r_ctl == FC_RCTL_DD_SOL_DATA && fh->fh_type == FC_TYPE_FCP)
                return 0;