ASoC: tas2562: remove useless assignment
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 12 Mar 2021 18:22:42 +0000 (12:22 -0600)
committerMark Brown <broonie@kernel.org>
Thu, 18 Mar 2021 13:50:51 +0000 (13:50 +0000)
cppcheck throws a warning:

sound/soc/codecs/tas2562.c:203:4: style: Assignment of function
parameter has no effect outside the function. [uselessAssignmentArg]
   tx_mask &= ~(1 << right_slot);
   ^

This assignment seems to come from a copy/paste but the value is
indeed not used. Let's remove it.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210312182246.5153-20-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2562.c

index 19965fa..ba23f9f 100644 (file)
@@ -200,7 +200,6 @@ static int tas2562_set_dai_tdm_slot(struct snd_soc_dai *dai,
                        right_slot = left_slot;
                } else {
                        right_slot = __ffs(tx_mask);
-                       tx_mask &= ~(1 << right_slot);
                }
        }