leds: trigger: Stop exporting trigger_list
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 31 Jan 2024 14:30:53 +0000 (15:30 +0100)
committerLee Jones <lee@kernel.org>
Thu, 7 Mar 2024 08:48:04 +0000 (08:48 +0000)
Commit 682e98564ffb ("leds: trigger: panic: Simplify
led_trigger_set_panic") removed the last external user of variable
trigger_list. So stop exporting it. If in future a need should arise
again to access this variable, I think we better add some accessor
instead of exporting the variable directly.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/ca185fb1-3a66-46b9-920e-bfecbe39c6bf@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/led-triggers.c
drivers/leds/leds.h

index 71cb0ae..3710007 100644 (file)
@@ -23,7 +23,7 @@
  * Nests outside led_cdev->trigger_lock
  */
 static DECLARE_RWSEM(triggers_list_lock);
-LIST_HEAD(trigger_list);
+static LIST_HEAD(trigger_list);
 
  /* Used by LED Class */
 
index 345062c..1138e2a 100644 (file)
@@ -30,7 +30,6 @@ ssize_t led_trigger_write(struct file *filp, struct kobject *kobj,
 
 extern struct rw_semaphore leds_list_lock;
 extern struct list_head leds_list;
-extern struct list_head trigger_list;
 extern const char * const led_colors[LED_COLOR_ID_MAX];
 
 #endif /* __LEDS_H_INCLUDED */