platform/x86: sony-laptop: Convert to use sysfs_emit_at() API
authorye xingchen <ye.xingchen@zte.com.cn>
Thu, 8 Dec 2022 07:45:17 +0000 (15:45 +0800)
committerHans de Goede <hdegoede@redhat.com>
Thu, 8 Dec 2022 16:12:28 +0000 (17:12 +0100)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212081545178689771@zte.com.cn
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/sony-laptop.c

index 765fcab..cd0f11e 100644 (file)
@@ -820,10 +820,9 @@ static ssize_t sony_nc_handles_show(struct device *dev,
        int i;
 
        for (i = 0; i < ARRAY_SIZE(handles->cap); i++) {
-               len += scnprintf(buffer + len, PAGE_SIZE - len, "0x%.4x ",
-                               handles->cap[i]);
+               len += sysfs_emit_at(buffer, len, "0x%.4x ", handles->cap[i]);
        }
-       len += scnprintf(buffer + len, PAGE_SIZE - len, "\n");
+       len += sysfs_emit_at(buffer, len, "\n");
 
        return len;
 }
@@ -2173,10 +2172,9 @@ static ssize_t sony_nc_thermal_profiles_show(struct device *dev,
 
        for (cnt = 0; cnt < THM_PROFILE_MAX; cnt++) {
                if (!cnt || (th_handle->profiles & cnt))
-                       idx += scnprintf(buffer + idx, PAGE_SIZE - idx, "%s ",
-                                       snc_thermal_profiles[cnt]);
+                       idx += sysfs_emit_at(buffer, idx, "%s ", snc_thermal_profiles[cnt]);
        }
-       idx += scnprintf(buffer + idx, PAGE_SIZE - idx, "\n");
+       idx += sysfs_emit_at(buffer, idx, "\n");
 
        return idx;
 }