staging: rtl8192e: Using comparison to true is error prone
authorJohn Oldman <john.oldman@polehill.co.uk>
Sat, 23 May 2020 17:28:12 +0000 (18:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 May 2020 08:16:33 +0000 (10:16 +0200)
clear below issues reported by checkpatch.pl:

CHECK: Using comparison to false is error prone

Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
Link: https://lore.kernel.org/r/20200523172812.16473-1-john.oldman@polehill.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl819x_HTProc.c

index d83d725..8abc921 100644 (file)
@@ -371,7 +371,7 @@ void HTConstructInfoElement(struct rtllib_device *ieee, u8 *posHTInfo,
        if ((ieee->iw_mode == IW_MODE_ADHOC) ||
            (ieee->iw_mode == IW_MODE_MASTER)) {
                pHTInfoEle->ControlChl  = ieee->current_network.channel;
-               pHTInfoEle->ExtChlOffset = ((pHT->bRegBW40MHz == false) ?
+               pHTInfoEle->ExtChlOffset = ((!pHT->bRegBW40MHz) ?
                                            HT_EXTCHNL_OFFSET_NO_EXT :
                                            (ieee->current_network.channel <= 6)
                                            ? HT_EXTCHNL_OFFSET_UPPER :
@@ -526,7 +526,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
        static u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
        static u8 EWC11NHTInfo[] = {0x00, 0x90, 0x4c, 0x34};
 
-       if (pHTInfo->bCurrentHTSupport == false) {
+       if (!pHTInfo->bCurrentHTSupport) {
                netdev_warn(ieee->dev, "%s(): HT_DISABLE\n", __func__);
                return;
        }
@@ -873,7 +873,7 @@ void HTSetConnectBwMode(struct rtllib_device *ieee,
 {
        struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
 
-       if (pHTInfo->bRegBW40MHz == false)
+       if (!pHTInfo->bRegBW40MHz)
                return;
 
        if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))