KVM: arm64: vgic: Kill VGIC_MAX_PRIVATE definition
authorMarc Zyngier <maz@kernel.org>
Sun, 17 Nov 2024 16:57:56 +0000 (16:57 +0000)
committerOliver Upton <oliver.upton@linux.dev>
Thu, 21 Nov 2024 01:21:08 +0000 (17:21 -0800)
VGIC_MAX_PRIVATE is a pretty useless definition, and is better
replaced with VGIC_NR_PRIVATE_IRQS.

Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20241117165757.247686-4-maz@kernel.org
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
arch/arm64/kvm/vgic/vgic.c
include/kvm/arm_vgic.h

index ffaa524..cc8c6b9 100644 (file)
@@ -106,8 +106,8 @@ struct vgic_irq *vgic_get_vcpu_irq(struct kvm_vcpu *vcpu, u32 intid)
                return NULL;
 
        /* SGIs and PPIs */
-       if (intid <= VGIC_MAX_PRIVATE) {
-               intid = array_index_nospec(intid, VGIC_MAX_PRIVATE + 1);
+       if (intid < VGIC_NR_PRIVATE_IRQS) {
+               intid = array_index_nospec(intid, VGIC_NR_PRIVATE_IRQS);
                return &vcpu->arch.vgic_cpu.private_irqs[intid];
        }
 
index f517254..3a8ccfd 100644 (file)
@@ -26,7 +26,6 @@
 #define VGIC_NR_SGIS           16
 #define VGIC_NR_PPIS           16
 #define VGIC_NR_PRIVATE_IRQS   (VGIC_NR_SGIS + VGIC_NR_PPIS)
-#define VGIC_MAX_PRIVATE       (VGIC_NR_PRIVATE_IRQS - 1)
 #define VGIC_MAX_SPI           1019
 #define VGIC_MAX_RESERVED      1023
 #define VGIC_MIN_LPI           8192