soundwire: stream: don't abort bank switch on Command_Ignored/-ENODATA
authorBard Liao <yung-chuan.liao@linux.intel.com>
Wed, 14 Jul 2021 03:22:04 +0000 (11:22 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 2 Aug 2021 05:38:22 +0000 (11:08 +0530)
This change is needed for support of mockup devices, which by
construction will not provide any answer to a bank switch, but it's
also legit for regular cases.

If for some reason a device loses sync and cannot handle a bank
switch, we should go ahead anyways. The devices can always resync
later.

The only case where the error flow should be used is when there is a
Command_Aborted composite answer from SoundWire devices.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20210714032209.11284-6-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/stream.c

index 1a18308..d84aaf1 100644 (file)
@@ -697,7 +697,7 @@ static int sdw_bank_switch(struct sdw_bus *bus, int m_rt_count)
        else
                ret = sdw_transfer(bus, wr_msg);
 
-       if (ret < 0) {
+       if (ret < 0 && ret != -ENODATA) {
                dev_err(bus->dev, "Slave frame_ctrl reg write failed\n");
                goto error;
        }