Bluetooth: btbcm: Use strreplace()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 17 Feb 2024 07:30:41 +0000 (08:30 +0100)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Wed, 6 Mar 2024 22:24:06 +0000 (17:24 -0500)
Use strreplace() instead of hand-writing it.
It is less verbose.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/btbcm.c

index 0a5445a..01d2343 100644 (file)
@@ -11,6 +11,7 @@
 #include <linux/firmware.h>
 #include <linux/dmi.h>
 #include <linux/of.h>
+#include <linux/string.h>
 #include <asm/unaligned.h>
 
 #include <net/bluetooth/bluetooth.h>
@@ -544,7 +545,6 @@ static const char *btbcm_get_board_name(struct device *dev)
        char *board_type;
        const char *tmp;
        int len;
-       int i;
 
        root = of_find_node_by_path("/");
        if (!root)
@@ -557,10 +557,7 @@ static const char *btbcm_get_board_name(struct device *dev)
        len = strlen(tmp) + 1;
        board_type = devm_kzalloc(dev, len, GFP_KERNEL);
        strscpy(board_type, tmp, len);
-       for (i = 0; i < len; i++) {
-               if (board_type[i] == '/')
-                       board_type[i] = '-';
-       }
+       strreplace(board_type, '/', '-');
        of_node_put(root);
 
        return board_type;