projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7acd695
)
wifi: rtw88: unlock on error path in rtw_ops_add_interface()
author
Dan Carpenter
<dan.carpenter@linaro.org>
Wed, 3 May 2023 15:09:55 +0000
(18:09 +0300)
committer
Kalle Valo
<kvalo@kernel.org>
Thu, 11 May 2023 13:17:53 +0000
(16:17 +0300)
Call mutex_unlock(&rtwdev->mutex); before returning on this error path.
Fixes:
f0e741e4ddbc
("wifi: rtw88: add bitmap for dynamic port settings")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link:
https://lore.kernel.org/r/ddd10a74-5982-4f65-8c59-c1cca558d239@kili.mountain
drivers/net/wireless/realtek/rtw88/mac80211.c
patch
|
blob
|
history
diff --git
a/drivers/net/wireless/realtek/rtw88/mac80211.c
b/drivers/net/wireless/realtek/rtw88/mac80211.c
index
7aa6eda
..
02cd19e
100644
(file)
--- a/
drivers/net/wireless/realtek/rtw88/mac80211.c
+++ b/
drivers/net/wireless/realtek/rtw88/mac80211.c
@@
-173,8
+173,10
@@
static int rtw_ops_add_interface(struct ieee80211_hw *hw,
mutex_lock(&rtwdev->mutex);
port = find_first_zero_bit(rtwdev->hw_port, RTW_PORT_NUM);
- if (port >= RTW_PORT_NUM)
+ if (port >= RTW_PORT_NUM) {
+ mutex_unlock(&rtwdev->mutex);
return -EINVAL;
+ }
set_bit(port, rtwdev->hw_port);
rtwvif->port = port;