platform/x86: thinkpad_acpi: Map Clipping tool hotkey to KEY_SELECTIVE_SCREENSHOT
authorHans de Goede <hdegoede@redhat.com>
Tue, 8 Sep 2020 19:21:50 +0000 (12:21 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 8 Sep 2020 23:31:17 +0000 (16:31 -0700)
Commit 696c6523ec8f ("platform/x86: thinkpad_acpi: add mapping for new
hotkeys") added support for a bunch of new hotkeys, but the
clipping/snipping tool hotkey got ignored because there was no good
key-code to map it to.

Recently a new KEY_SELECTIVE_SCREENSHOT keycode was added by commit
3b059da9835c ("Input: allocate keycode for "Selective Screenshot" key")
quoting from the commit message:

"New Chrome OS keyboards have a "snip" key that is basically a selective
screenshot (allows a user to select an area of screen to be copied).
Allocate a keycode for it."

Support for this "snip" key seems like it is also a good match for the
clipping/snipping tool hotkey, so map this hotkey to the new
KEY_SELECTIVE_SCREENSHOT key-code.

Reviewed-by: Bastien Nocera <hadess@hadess.net>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20200908135147.4044-5-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/platform/x86/thinkpad_acpi.c

index c09933a..fd93df4 100644 (file)
@@ -3451,7 +3451,7 @@ static int __init hotkey_init(struct ibm_init_struct *iibm)
                KEY_UNKNOWN,
 
                KEY_BOOKMARKS,                  /* Favorite app, 0x311 */
-               KEY_RESERVED,                   /* Clipping tool */
+               KEY_SELECTIVE_SCREENSHOT,       /* Clipping tool */
                KEY_CALC,                       /* Calculator (above numpad, P52) */
                KEY_BLUETOOTH,                  /* Bluetooth */
                KEY_KEYBOARD,                   /* Keyboard, 0x315 */