nfsd: print 64-bit timestamps in client_info_show
authorArnd Bergmann <arnd@arndb.de>
Thu, 31 Oct 2019 13:52:43 +0000 (14:52 +0100)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 19 Dec 2019 22:46:08 +0000 (17:46 -0500)
The nii_time field gets truncated to 'time_t' on 32-bit architectures
before printing.

Remove the use of 'struct timespec' to product the correct output
beyond 2038.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c
fs/nfsd/state.h

index 7bba1e1..27e1c12 100644 (file)
@@ -2341,7 +2341,7 @@ static int client_info_show(struct seq_file *m, void *v)
                                        clp->cl_nii_domain.len);
                seq_printf(m, "\nImplementation name: ");
                seq_quote_mem(m, clp->cl_nii_name.data, clp->cl_nii_name.len);
-               seq_printf(m, "\nImplementation time: [%ld, %ld]\n",
+               seq_printf(m, "\nImplementation time: [%lld, %ld]\n",
                        clp->cl_nii_time.tv_sec, clp->cl_nii_time.tv_nsec);
        }
        drop_client(clp);
@@ -2995,8 +2995,7 @@ static __be32 copy_impl_id(struct nfs4_client *clp,
        xdr_netobj_dup(&clp->cl_nii_name, &exid->nii_name, GFP_KERNEL);
        if (!clp->cl_nii_name.data)
                return nfserr_jukebox;
-       clp->cl_nii_time.tv_sec = exid->nii_time.tv_sec;
-       clp->cl_nii_time.tv_nsec = exid->nii_time.tv_nsec;
+       clp->cl_nii_time = exid->nii_time;
        return 0;
 }
 
index ffc590d..6cf4420 100644 (file)
@@ -340,7 +340,7 @@ struct nfs4_client {
        /* NFSv4.1 client implementation id: */
        struct xdr_netobj       cl_nii_domain;
        struct xdr_netobj       cl_nii_name;
-       struct timespec         cl_nii_time;
+       struct timespec64       cl_nii_time;
 
        /* for v4.0 and v4.1 callbacks: */
        struct nfs4_cb_conn     cl_cb_conn;