staging: vme_user: prefer strscpy over strcpy
authorMichael Straube <straube.linux@gmail.com>
Mon, 23 Oct 2023 09:00:01 +0000 (11:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Oct 2023 10:57:46 +0000 (12:57 +0200)
Using strcpy has potential for buffer overflows. It should be replaced
with strscpy where possible. In this case the return value of strcpy is
not used, so we can safely replace it with strscpy.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20231023090001.7273-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vme_user/vme_tsi148.c

index d549c22..2ec9c29 100644 (file)
@@ -2310,7 +2310,7 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
        mutex_init(&tsi148_device->vme_rmw);
 
        tsi148_bridge->parent = &pdev->dev;
-       strcpy(tsi148_bridge->name, driver_name);
+       strscpy(tsi148_bridge->name, driver_name, VMENAMSIZ);
 
        /* Setup IRQ */
        retval = tsi148_irq_init(tsi148_bridge);