nvme-fabrics: remove superfluous nvmf_host_put in nvmf_parse_options
authorHou Pu <houpu.main@gmail.com>
Fri, 9 Jul 2021 02:32:47 +0000 (10:32 +0800)
committerChristoph Hellwig <hch@lst.de>
Mon, 16 Aug 2021 12:42:23 +0000 (14:42 +0200)
Opts->host is NULL there. It is checked just before. So remove
nvmf_host_put. It is introduced by commit 59a2f3f00fd7 ("nvme: fix
potential memory leak in option parsing").

Signed-off-by: Hou Pu <houpu.main@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/fabrics.c

index a5469fd..668c6bb 100644 (file)
@@ -719,7 +719,6 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
                                ret = -EINVAL;
                                goto out;
                        }
-                       nvmf_host_put(opts->host);
                        opts->host = nvmf_host_add(p);
                        kfree(p);
                        if (!opts->host) {