thermal: cpu_cooling: don't iterate over all allowed_cpus to update cpufreq policy
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 4 Dec 2014 04:11:56 +0000 (09:41 +0530)
committerEduardo Valentin <edubezval@gmail.com>
Mon, 8 Dec 2014 16:08:56 +0000 (12:08 -0400)
All CPUs present in 'allowed_cpus' share the same 'struct cpufreq_policy'
structure and so calling cpufreq_update_policy() for each of them doesn't make
sense.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/cpu_cooling.c

index f325738..7f27f1b 100644 (file)
@@ -285,11 +285,10 @@ static unsigned int get_cpu_frequency(unsigned int cpu, unsigned long level)
 static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
                                 unsigned long cooling_state)
 {
-       unsigned int cpuid, clip_freq;
+       unsigned int clip_freq;
        struct cpumask *mask = &cpufreq_device->allowed_cpus;
        unsigned int cpu = cpumask_any(mask);
 
-
        /* Check if the old cooling action is same as new cooling action */
        if (cpufreq_device->cpufreq_state == cooling_state)
                return 0;
@@ -301,10 +300,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
        cpufreq_device->cpufreq_state = cooling_state;
        cpufreq_device->cpufreq_val = clip_freq;
 
-       for_each_cpu(cpuid, mask) {
-               if (is_cpufreq_valid(cpuid))
-                       cpufreq_update_policy(cpuid);
-       }
+       if (is_cpufreq_valid(cpu))
+               cpufreq_update_policy(cpu);
 
        return 0;
 }