nvme/multipath: Use blk_path_error
authorKeith Busch <keith.busch@intel.com>
Tue, 9 Jan 2018 19:04:17 +0000 (12:04 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 10 Jan 2018 17:52:18 +0000 (10:52 -0700)
Uses common code for determining if an error should be retried on
alternate path.

Acked-by: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/multipath.c

index ae9abb6..3b211d9 100644 (file)
@@ -37,19 +37,7 @@ bool nvme_req_needs_failover(struct request *req, blk_status_t error)
 {
        if (!(req->cmd_flags & REQ_NVME_MPATH))
                return false;
-
-       switch (error) {
-       case BLK_STS_NOTSUPP:
-       case BLK_STS_NOSPC:
-       case BLK_STS_TARGET:
-       case BLK_STS_NEXUS:
-       case BLK_STS_MEDIUM:
-       case BLK_STS_PROTECTION:
-               return false;
-       }
-
-       /* Everything else could be a path failure, so should be retried */
-       return true;
+       return blk_path_error(error);
 }
 
 void nvme_kick_requeue_lists(struct nvme_ctrl *ctrl)