drm/i915: Nuke pointless variable
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 30 Jun 2020 21:56:01 +0000 (00:56 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 15 Sep 2020 15:01:57 +0000 (18:01 +0300)
No point in assigning the function return value to a local
variable if we're just going to use it the one time.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200630215601.28557-13-ville.syrjala@linux.intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
drivers/gpu/drm/i915/display/intel_hotplug.c

index f3dbf2b..5c58c1e 100644 (file)
@@ -482,7 +482,6 @@ void intel_hpd_irq_handler(struct drm_i915_private *dev_priv,
         * only the one of them (DP) will have ->hpd_pulse().
         */
        for_each_intel_encoder(&dev_priv->drm, encoder) {
-               bool has_hpd_pulse = intel_encoder_has_hpd_pulse(encoder);
                enum port port = encoder->port;
                bool long_hpd;
 
@@ -490,7 +489,7 @@ void intel_hpd_irq_handler(struct drm_i915_private *dev_priv,
                if (!(BIT(pin) & pin_mask))
                        continue;
 
-               if (!has_hpd_pulse)
+               if (!intel_encoder_has_hpd_pulse(encoder))
                        continue;
 
                long_hpd = long_mask & BIT(pin);