drm/msm: Fix incorrect file name output in adreno_request_fw()
authorAleksandr Mishin <amishin@t-argos.ru>
Fri, 5 Jul 2024 09:13:12 +0000 (12:13 +0300)
committerRob Clark <robdclark@chromium.org>
Fri, 30 Aug 2024 17:41:19 +0000 (10:41 -0700)
In adreno_request_fw() when debugging information is printed to the log
after firmware load, an incorrect filename is printed. 'newname' is used
instead of 'fwname', so prefix "qcom/" is being added to filename.
Looks like "copy-paste" mistake.

Fix this mistake by replacing 'newname' with 'fwname'.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 2c41ef1b6f7d ("drm/msm/adreno: deal with linux-firmware fw paths")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/602382/
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/adreno_gpu.c

index f742ebe..7620654 100644 (file)
@@ -484,7 +484,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const char *fwname)
                ret = request_firmware_direct(&fw, fwname, drm->dev);
                if (!ret) {
                        DRM_DEV_INFO(drm->dev, "loaded %s from legacy location\n",
-                               newname);
+                               fwname);
                        adreno_gpu->fwloc = FW_LOCATION_LEGACY;
                        goto out;
                } else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) {