wifi: ath9k: Make arrays prof_prio and channelmap static const
authorColin Ian King <colin.i.king@gmail.com>
Wed, 5 Oct 2022 15:55:58 +0000 (16:55 +0100)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 10 Oct 2022 09:45:54 +0000 (12:45 +0300)
Don't populate the read-only arrays prof_prio and channelmap
on the stack but instead make them static const. Also makes the
object code a little smaller.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20221005155558.320556-1-colin.i.king@gmail.com
drivers/net/wireless/ath/ath9k/mci.c

index 039bf0c..3363fc4 100644 (file)
@@ -266,7 +266,9 @@ static void ath_mci_set_concur_txprio(struct ath_softc *sc)
                        stomp_txprio[ATH_BTCOEX_STOMP_NONE] =
                                ATH_MCI_INQUIRY_PRIO;
        } else {
-               u8 prof_prio[] = { 50, 90, 94, 52 };/* RFCOMM, A2DP, HID, PAN */
+               static const u8 prof_prio[] = {
+                       50, 90, 94, 52
+               }; /* RFCOMM, A2DP, HID, PAN */
 
                stomp_txprio[ATH_BTCOEX_STOMP_LOW] =
                stomp_txprio[ATH_BTCOEX_STOMP_NONE] = 0xff;
@@ -644,7 +646,9 @@ void ath9k_mci_update_wlan_channels(struct ath_softc *sc, bool allow_all)
        struct ath_hw *ah = sc->sc_ah;
        struct ath9k_hw_mci *mci = &ah->btcoex_hw.mci;
        struct ath9k_channel *chan = ah->curchan;
-       u32 channelmap[] = {0x00000000, 0xffff0000, 0xffffffff, 0x7fffffff};
+       static const u32 channelmap[] = {
+               0x00000000, 0xffff0000, 0xffffffff, 0x7fffffff
+       };
        int i;
        s16 chan_start, chan_end;
        u16 wlan_chan;