spi: bcm2835: depends GPIOLIB
authorYoshinori Sato <ysato@users.sourceforge.jp>
Sun, 3 May 2015 15:16:36 +0000 (00:16 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 4 May 2015 12:57:36 +0000 (13:57 +0100)
I got following error on CONFIG_GPIOLIB=n.

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error: dereferencing pointer to incomplete type 'struct gpio_chip'
  return !strcmp(chip->label, data);
                     ^
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:9: error: implicit declaration of function 'gpiochip_find' [-Werror=implicit-function-declaration]
  chip = gpiochip_find("pinctrl-bcm2835", chip_match_name);
         ^
drivers/spi/spi-bcm2835.c:382:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  chip = gpiochip_find("pinctrl-bcm2835", chip_match_name);
       ^
drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:357:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/Kconfig

index 198f96b..d5ed2a0 100644 (file)
@@ -77,6 +77,7 @@ config SPI_ATMEL
 
 config SPI_BCM2835
        tristate "BCM2835 SPI controller"
+       depends on GPIOLIB
        depends on ARCH_BCM2835 || COMPILE_TEST
        help
          This selects a driver for the Broadcom BCM2835 SPI master.