scsi: tcmu: refactor add_device cmd with new nl helpers
authorZhu Lingshan <lszhu@suse.com>
Wed, 2 May 2018 03:13:40 +0000 (11:13 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 8 May 2018 05:52:49 +0000 (01:52 -0400)
use new netlink events helpers tcmu_netlink_init() and
tcmu_netlink_send() to refactor netlink event TCMU_CMD_ADDED_DEVICE

Signed-off-by: Zhu Lingshan <lszhu@suse.com>
Acked-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_user.c

index 82f424d..b0e3f03 100644 (file)
@@ -1716,6 +1716,21 @@ static int tcmu_netlink_event_send(struct tcmu_dev *udev,
        return ret;
 }
 
+static int tcmu_send_dev_add_event(struct tcmu_dev *udev)
+{
+       struct sk_buff *skb = NULL;
+       void *msg_header = NULL;
+       int ret = 0;
+
+       ret = tcmu_netlink_event_init(udev, TCMU_CMD_ADDED_DEVICE, &skb,
+                                     &msg_header);
+       if (ret < 0)
+               return ret;
+       return tcmu_netlink_event_send(udev, TCMU_CMD_ADDED_DEVICE, &skb,
+                                      &msg_header);
+
+}
+
 static int tcmu_update_uio_info(struct tcmu_dev *udev)
 {
        struct tcmu_hba *hba = udev->hba->hba_ptr;
@@ -1825,7 +1840,7 @@ static int tcmu_configure_device(struct se_device *dev)
         */
        kref_get(&udev->kref);
 
-       ret = tcmu_netlink_event(udev, TCMU_CMD_ADDED_DEVICE, 0, NULL);
+       ret = tcmu_send_dev_add_event(udev);
        if (ret)
                goto err_netlink;