ceph: fix incorrect use of strncpy
authorYan, Zheng <zyan@redhat.com>
Mon, 2 Jul 2018 07:55:23 +0000 (15:55 +0800)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 2 Aug 2018 19:26:11 +0000 (21:26 +0200)
GCC8 prints following warning:

 fs/ceph/mds_client.c:3683:2: warning: ‘strncpy’ output may be truncated
 copying 64 bytes from a string of length 64 [-Wstringop-truncation]

[ Change to strscpy() while at it. ]

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/mds_client.c

index dc8bc66..f159025 100644 (file)
@@ -3644,8 +3644,8 @@ int ceph_mdsc_init(struct ceph_fs_client *fsc)
        init_rwsem(&mdsc->pool_perm_rwsem);
        mdsc->pool_perm_tree = RB_ROOT;
 
-       strncpy(mdsc->nodename, utsname()->nodename,
-               sizeof(mdsc->nodename) - 1);
+       strscpy(mdsc->nodename, utsname()->nodename,
+               sizeof(mdsc->nodename));
        return 0;
 }