pinctrl: nomadik: minimise indentation in probe

nmk_pinctrl_probe() iterates over each GPIO block. Use an early
conditional continue to skip to the next iteration rather than indent
all the loop code block.

Do not change code logic. The block is changed from:

	for (i = 0; i < NMK_MAX_BANKS; i++) {
		x = of_parse_phandle(...);
		if (x) {
			... do work ...
		}
	}

To:

	for (i = 0; i < NMK_MAX_BANKS; i++) {
		x = of_parse_phandle(...);
		if (!x)
			continue;

		... do work ...
	}

Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Link: https://lore.kernel.org/r/20240228-mbly-gpio-v2-10-3ba757474006@bootlin.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index c8d2699..69b421b 100644 (file)
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1203,17 +1203,16 @@ static int nmk_pinctrl_probe(struct platform_device *pdev)
                struct nmk_gpio_chip *nmk_chip;
 
                gpio_np = of_parse_phandle(np, "nomadik-gpio-chips", i);
-               if (gpio_np) {
-                       dev_info(&pdev->dev,
-                                "populate NMK GPIO %d \"%pOFn\"\n",
-                                i, gpio_np);
-                       nmk_chip = nmk_gpio_populate_chip(gpio_np, pdev);
-                       if (IS_ERR(nmk_chip))
-                               dev_err(&pdev->dev,
-                                       "could not populate nmk chip struct "
-                                       "- continue anyway\n");
-                       of_node_put(gpio_np);
-               }
+               if (!gpio_np)
+                       continue;
+
+               dev_info(&pdev->dev, "populate NMK GPIO %d \"%pOFn\"\n",
+                        i, gpio_np);
+               nmk_chip = nmk_gpio_populate_chip(gpio_np, pdev);
+               if (IS_ERR(nmk_chip))
+                       dev_err(&pdev->dev,
+                               "could not populate nmk chip struct - continue anyway\n");
+               of_node_put(gpio_np);
        }
 
        prcm_np = of_parse_phandle(np, "prcm", 0);