vmlinux.lds.h: Add .gnu.version* to COMMON_DISCARDS
authorKees Cook <keescook@chromium.org>
Fri, 21 Aug 2020 19:42:43 +0000 (12:42 -0700)
committerIngo Molnar <mingo@kernel.org>
Tue, 1 Sep 2020 07:50:35 +0000 (09:50 +0200)
For vmlinux linking, no architecture uses the .gnu.version* sections,
so remove it via the COMMON_DISCARDS macro in preparation for adding
--orphan-handling=warn more widely. This is a work-around for what
appears to be a bug[1] in ld.bfd which warns for this synthetic section
even when none is found in input objects, and even when no section is
emitted for an output object[2].

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=26153
[2] https://lore.kernel.org/lkml/202006221524.CEB86E036B@keescook/

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Fangrui Song <maskray@google.com>
Cc: linux-arch@vger.kernel.org
Link: https://lore.kernel.org/r/20200821194310.3089815-3-keescook@chromium.org
include/asm-generic/vmlinux.lds.h

index 184b23d..f1f02a2 100644 (file)
 #define COMMON_DISCARDS                                                        \
        *(.discard)                                                     \
        *(.discard.*)                                                   \
-       *(.modinfo)
+       *(.modinfo)                                                     \
+       /* ld.bfd warns about .gnu.version* even when not emitted */    \
+       *(.gnu.version*)                                                \
 
 #define DISCARDS                                                       \
        /DISCARD/ : {                                                   \