mctp: remove duplicated assignment of pointer hdr
authorColin Ian King <colin.king@canonical.com>
Wed, 4 Aug 2021 12:15:30 +0000 (13:15 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Aug 2021 09:56:01 +0000 (10:56 +0100)
The pointer hdr is being initialized and also re-assigned with the
same value from the call to function mctp_hdr. Static analysis reports
that the initializated value is unused. The second assignment is
duplicated and can be removed.

Addresses-Coverity: ("Unused value").
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mctp/af_mctp.c

index 84f722d..a9526ac 100644 (file)
@@ -170,7 +170,6 @@ static int mctp_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
                /* TODO: expand mctp_skb_cb for header fields? */
                struct mctp_hdr *hdr = mctp_hdr(skb);
 
-               hdr = mctp_hdr(skb);
                addr = msg->msg_name;
                addr->smctp_family = AF_MCTP;
                addr->smctp_network = cb->net;