drm/amdgpu/pm: Fix uninitialized variable agc_btc_response
authorMa Jun <Jun.Ma2@amd.com>
Sun, 28 Apr 2024 06:41:38 +0000 (14:41 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 8 May 2024 19:17:04 +0000 (15:17 -0400)
Assign an default value to agc_btc_response in failed case

Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c

index 37c915d..3b461c0 100644 (file)
@@ -2361,15 +2361,20 @@ static int vega10_acg_enable(struct pp_hwmgr *hwmgr)
 {
        struct vega10_hwmgr *data = hwmgr->backend;
        uint32_t agc_btc_response;
+       int ret;
 
        if (data->smu_features[GNLD_ACG].supported) {
                if (0 == vega10_enable_smc_features(hwmgr, true,
                                        data->smu_features[GNLD_DPM_PREFETCHER].smu_feature_bitmap))
                        data->smu_features[GNLD_DPM_PREFETCHER].enabled = true;
 
-               smum_send_msg_to_smc(hwmgr, PPSMC_MSG_InitializeAcg, NULL);
+               ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_InitializeAcg, NULL);
+               if (ret)
+                       return ret;
 
-               smum_send_msg_to_smc(hwmgr, PPSMC_MSG_RunAcgBtc, &agc_btc_response);
+               ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_RunAcgBtc, &agc_btc_response);
+               if (ret)
+                       agc_btc_response = 0;
 
                if (1 == agc_btc_response) {
                        if (1 == data->acg_loop_state)