drm/amd/display: Reset VRR config during resume
authorTom Chung <chiahsuan.chung@amd.com>
Fri, 12 Jul 2024 09:29:07 +0000 (17:29 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Sat, 27 Jul 2024 21:32:32 +0000 (17:32 -0400)
[Why]
After resume the system, the new_crtc_state->vrr_infopacket does not
synchronize with the current state.  It will affect the
update_freesync_state_on_stream() does not update the state correctly.

The previous patch causes a PSR SU regression that cannot let panel go
into self-refresh mode.

[How]
Reset the VRR config during resume to force update the VRR config later.

Fixes: eb6dfbb7a9c6 ("drm/amd/display: Reset freesync config before update new state")
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
Reviewed-by: Sun peng Li <sunpeng.li@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 5b1e313..b4fbccb 100644 (file)
@@ -176,6 +176,7 @@ MODULE_FIRMWARE(FIRMWARE_DCN_401_DMUB);
 static int amdgpu_dm_init(struct amdgpu_device *adev);
 static void amdgpu_dm_fini(struct amdgpu_device *adev);
 static bool is_freesync_video_mode(const struct drm_display_mode *mode, struct amdgpu_dm_connector *aconnector);
+static void reset_freesync_config_for_crtc(struct dm_crtc_state *new_crtc_state);
 
 static enum drm_mode_subconnector get_subconnector_type(struct dc_link *link)
 {
@@ -3213,8 +3214,11 @@ static int dm_resume(void *handle)
        drm_connector_list_iter_end(&iter);
 
        /* Force mode set in atomic commit */
-       for_each_new_crtc_in_state(dm->cached_state, crtc, new_crtc_state, i)
+       for_each_new_crtc_in_state(dm->cached_state, crtc, new_crtc_state, i) {
                new_crtc_state->active_changed = true;
+               dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
+               reset_freesync_config_for_crtc(dm_new_crtc_state);
+       }
 
        /*
         * atomic_check is expected to create the dc states. We need to release