drm/tilcdc: fix raster control register setting
authorDario Binacchi <dariobin@libero.it>
Tue, 16 Feb 2021 20:22:25 +0000 (21:22 +0100)
committerJyri Sarha <jyri.sarha@iki.fi>
Thu, 18 Feb 2021 16:04:11 +0000 (18:04 +0200)
The fdd property of the tilcdc_panel_info structure must set the reqdly
bit field  (bit 12 to 19) of the raster control register. The previous
statement set the least significant bit instead.

Signed-off-by: Dario Binacchi <dariobin@libero.it>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
Tested-by: Jyri Sarha <jyri.sarha@iki.fi>
Signed-off-by: Jyri Sarha <jyri.sarha@iki.fi>
Link: https://patchwork.freedesktop.org/patch/msgid/20210216202225.12861-1-dariobin@libero.it
drivers/gpu/drm/tilcdc/tilcdc_crtc.c

index 783ae9d..21e7b3d 100644 (file)
@@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc)
                        return;
                }
        }
-       reg |= info->fdd < 12;
+       reg |= info->fdd << 12;
        tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg);
 
        if (info->invert_pxl_clk)